Move message history out of core#21278
Merged
Merged
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: f4ae2d0e54
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
fcoury-oai
approved these changes
May 6, 2026
Contributor
fcoury-oai
left a comment
fcoury-oai
left a comment
There was a problem hiding this comment.
Executed happy path smoke test sending messages and making sure we can recall them from history both in the same and new sessions.
Code looks good, approved.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Message history was implemented inside
codex-coreand surfaced through core protocol ops andSessionConfiguredEventfields even though the current consumer is TUI-local prompt recall. That made core own UI history persistence and exposedhistory_log_id/history_entry_countthrough surfaces that app-server and other clients do not need.This change moves message history persistence out of core and keeps the recall plumbing local to the TUI.
What changed
codex-message-historycrate for appending, looking up, trimming, and reading metadata fromhistory.jsonl.AddToHistory,GetHistoryEntryRequest, andGetHistoryEntryResponse.history_log_idandhistory_entry_countfromSessionConfiguredEventand updated exec/MCP/test fixtures accordingly.Validation
cargo test -p codex-message-history -p codex-protocolcargo test -p codex-exec event_processor_with_json_outputcargo test -p codex-mcp-server outgoing_messagecargo test -p codex-tuijust fix -p codex-message-history -p codex-protocol -p codex-core -p codex-tui -p codex-exec -p codex-mcp-server