Skip to content

[codex] Remove legacy ListSkills op#21282

Merged
pakrym-oai merged 1 commit into
mainfrom
pakrym/delete-list-skills-op
May 6, 2026
Merged

[codex] Remove legacy ListSkills op#21282
pakrym-oai merged 1 commit into
mainfrom
pakrym/delete-list-skills-op

Conversation

@pakrym-oai
Copy link
Copy Markdown
Collaborator

@pakrym-oai pakrym-oai commented May 6, 2026

Why

skills/list is already exposed through app-server v2 and covered by the app-server test suite. Keeping the separate core Op::ListSkills path leaves a duplicate legacy protocol surface that no longer needs to be maintained.

What Changed

  • Removed Op::ListSkills and EventMsg::ListSkillsResponse from the core protocol.
  • Deleted the corresponding core session handler and stale core integration tests.
  • Removed rollout/MCP ignore branches and protocol v1 docs references for the deleted event/op.
  • Left app-server skills/list and its existing coverage intact.

Validation

  • cargo test -p codex-protocol
  • cargo test -p codex-core --test all suite::skills
  • cargo check -p codex-mcp-server -p codex-rollout -p codex-rollout-trace
  • just fix -p codex-core

@pakrym-oai pakrym-oai marked this pull request as ready for review May 6, 2026 01:20
@pakrym-oai pakrym-oai requested a review from a team as a code owner May 6, 2026 01:20
Copy link
Copy Markdown
Contributor

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 01e6ce7f02

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

Comment thread codex-rs/protocol/src/protocol.rs
@pakrym-oai pakrym-oai force-pushed the pakrym/delete-list-skills-op branch from 01e6ce7 to 1eab247 Compare May 6, 2026 01:28
@pakrym-oai pakrym-oai marked this pull request as draft May 6, 2026 01:29
@pakrym-oai pakrym-oai marked this pull request as ready for review May 6, 2026 01:32
@pakrym-oai pakrym-oai enabled auto-merge (squash) May 6, 2026 01:33
@pakrym-oai pakrym-oai disabled auto-merge May 6, 2026 01:58
@pakrym-oai pakrym-oai merged commit 136e442 into main May 6, 2026
37 of 38 checks passed
@pakrym-oai pakrym-oai deleted the pakrym/delete-list-skills-op branch May 6, 2026 01:58
@github-actions github-actions Bot locked and limited conversation to collaborators May 6, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants