[codex] Split tool handlers into separate files#21395
Merged
Merged
Conversation
jif-oai
approved these changes
May 6, 2026
Collaborator
jif-oai
left a comment
jif-oai
left a comment
There was a problem hiding this comment.
That looks like a very big PR for a still non-final architecture. This will creates a lot of conflicts and make any revert of PRs before this one more difficult
I understand the rational though so I let you decide if you want to merge
| } | ||
| } | ||
|
|
||
| pub(super) fn resolve_use_login_shell( |
Collaborator
There was a problem hiding this comment.
Ultra nit but putting think in pub just for testing is in general an hint of a design issue
Good for now though. This is still in design
…dlers-one-per-file
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Several tool handler modules still bundled multiple
ToolHandlerimplementations in one file. That made the handler directory harder to navigate and made otherwise local handler edits land in large shared modules.What
ShellCommandHandlerthrough the existingShellCommandBackendConfigconversion now that the backend detail lives with the shell-command handler.Validation
cargo check -p codex-corecargo clippy -p codex-core --lib -- -D warningsgit diff --check -- codex-rs/core/src/tools/handlersTargeted
codex-corehandler tests did not run locally becausecore_test_supportcurrently fails to compile before reaching these tests due to an unresolvedsimilarimport.