Skip to content

[codex-tui] pass thread source for tui threads#21401

Merged
rhan-oai merged 1 commit into
mainfrom
rhan/thread-source-tui
May 6, 2026
Merged

[codex-tui] pass thread source for tui threads#21401
rhan-oai merged 1 commit into
mainfrom
rhan/thread-source-tui

Conversation

@rhan-oai
Copy link
Copy Markdown
Collaborator

@rhan-oai rhan-oai commented May 6, 2026

Summary

  • mark TUI-created thread starts and forks with explicit thread_source = user
  • add focused coverage for embedded and remote lifecycle request builders

Why

Thread analytics now consume an explicit thread-level source classification instead of inferring it from session_source. The TUI still omitted that field, so TUI-created interactive threads would continue to land as null even after the new analytics plumbing shipped.

Validation

  • cargo test -p codex-tui app_server_session --lib

@rhan-oai rhan-oai force-pushed the rhan/thread-source-tui branch from 6aaec45 to 1f9dae1 Compare May 6, 2026 19:41
@rhan-oai rhan-oai marked this pull request as ready for review May 6, 2026 19:49
@rhan-oai rhan-oai merged commit 21295f4 into main May 6, 2026
26 checks passed
@rhan-oai rhan-oai deleted the rhan/thread-source-tui branch May 6, 2026 20:18
@github-actions github-actions Bot locked and limited conversation to collaborators May 6, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants