[codex] Delete tool handler plan indirection#21427
Merged
Merged
Conversation
…ndler-kind # Conflicts: # codex-rs/core/src/tools/spec.rs # codex-rs/core/src/tools/spec_plan.rs # codex-rs/core/src/tools/spec_plan_tests.rs # codex-rs/core/src/tools/spec_plan_types.rs
sayan-oai
approved these changes
May 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The spec split in the parent PR still left an intermediate registry plan that recorded
ToolHandlerKindvalues and translated them into concrete handlers later. That kept tool registration dependent on static enum bookkeeping instead of registering handlers from the same code that assembles their specs.What Changed
build_tool_registry_builderregister concrete handlers directly while adding specs.ToolRegistryBuilderhelpers for spec augmentation and nested code-mode inspection.ToolHandlerKind,ToolHandlerSpec, andToolRegistryPlan.ToolRegistryinstead of static handler descriptors.Validation
cargo check -p codex-corecargo test -p codex-core tools::spec_plan::testscargo test -p codex-core tools::spec::testsjust fix -p codex-core