Revert state DB injection and agent graph store#21481
Merged
Merged
Conversation
This reverts commit 7e310bc.
pakrym-oai
force-pushed
the
pakrym/revert-20689-db-store
branch
from
1865af5 to
0035356
Compare
Collaborator
Author
|
@codex review this |
etraut-openai
approved these changes
May 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Reverts #20689 to restore the previous optional state DB plumbing. The conflict resolution keeps the newer installation ID and session/thread identity changes that landed after #20689, while removing the mandatory state DB and agent graph store dependency from ThreadManager construction.
What changed
Option<StateDbHandle>through app-server, MCP server, prompt debug, and test entry points.codex-coredependency oncodex-agent-graph-storeand reverted descendant lookup back to the existing state DB path when available.installation_idforwarding by passing it beside the optional DB handle.Validation
git diff --checkcargo test -p codex-thread-storecargo test -p codex-state -p codex-rollout -p codex-app-server-protocolenv CARGO_INCREMENTAL=0 cargo test -p codex-core -p codex-app-server -p codex-app-server-client -p codex-mcp-server -p codex-thread-manager-sample -p codex-tui; blocked locally by a rustc ICE while compilingv8 v146.4.0withrustc 1.93.0 (254b59607 2026-01-19)onaarch64-apple-darwin.