Grant sandbox users access to desktop runtime bin#21564
Merged
Conversation
20a80e1 to
c428356
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Codex desktop copies bundled Windows binaries out of
WindowsAppsinto a LocalAppData runtime cache before launchingcodex.exe. Sandboxed commands can then need to execute helpers from that cache, but the sandbox user group may not have read/execute access to the runtime bin directory.This makes the Windows sandbox refresh path repair that access directly so the packaged desktop runtime remains usable from sandboxed sessions.
What changed
setup_runtime_binto locate%LOCALAPPDATA%\OpenAI\Codex\bin, matching the desktop bundled-binaries destination path, with the sameUSERPROFILE\AppData\Localfallback shape.CodexSandboxUsersalready has read/execute access to the runtime bin directory.CodexSandboxUsersOI/CI/RXinheritance on that directory.Verification
cargo build -p codex-windows-sandbox --bin codex-windows-sandbox-setupcargo test -p codex-windows-sandbox --bin codex-windows-sandbox-setupCodexSandboxUsers:(I)(OI)(CI)(RX)no-ops without changing SDDLCodexSandboxUsers:(OI)(CI)(RX)LOCALAPPDATApointed at a fake location withoutOpenAI\Codex\bin, setup exits successfully and does not create the directory