Fix rust-ci-full failures due to missing bwrap#21604
Merged
Merged
Conversation
zanie-oai
changed the title
rust-ci-full
The rust-ci-full remote Linux tests run the exec server inside an Ubuntu Docker container. Install bubblewrap there too so sandboxed commands can find system bwrap on PATH.\n\nCo-authored-by: Codex <noreply@openai.com>
The remote exec-server in rust-ci-full can start with / as its current directory. Treating that root cwd like a workspace path caused system bwrap candidates such as /usr/bin/bwrap to be filtered out as local binaries. Keep excluding bwrap candidates inside non-root cwd values, but allow normal PATH lookup when cwd is root. Co-authored-by: Codex <noreply@openai.com>
zanie-oai
changed the title
rust-ci-fullrust-ci-full failures due to missing bwrap
bolinfest
approved these changes
May 8, 2026
Collaborator
bolinfest
left a comment
bolinfest
left a comment
There was a problem hiding this comment.
Great find: ty!
I had noticed that rust-ci-full was...more red...than usual but didn't have a chance to investigate. This explains a lot!
| ); | ||
| } | ||
|
|
||
| #[test] |
Collaborator
There was a problem hiding this comment.
Should this be cfg(unix) due to the Path::new("/")?
Contributor
Author
There was a problem hiding this comment.
This whole file is restricted to Linux already, so it'd be superfluous. Path::new("/") is fine on Windows regardless, the intent of the test just might not be relevant.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since #21255,
rust-ci-fullhas been failing due to a missingbwrap.Since the happy path is now to use the system binary, let's ensure that's installed.
8d51826 was necessary for the
bwrapexecutable to be discoverable when the working directory is/.I ran
rust-ci-fullat https://github.com/openai/codex/actions/runs/25528074506