Omit service_tier from remote /responses/compact requests under API auth#21676
Merged
Conversation
aibrahim-oai
changed the title
aibrahim-oai
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
API-key-auth remote compaction requests should not inherit
service_tierfrom normal/responsesturns. This path needs to match API auth expectations, while ChatGPT-auth remote compaction should keep reusing the shared request fields that still apply there.This change keeps the decision inline in
codex-rs/core/src/compact_remote.rsonly. Under API key auth, the classic remote/responses/compactpath now omitsservice_tier; under ChatGPT auth, it keeps reusing the configured tier.codex-rs/core/src/compact_remote_v2.rsis unchanged. The remote compaction parity coverage and snapshots were updated to assert the API-key omission and preserve the ChatGPT-auth behavior.Testing
codex-rs/core/tests/suite/compact_remote.rsand the corresponding snapshots.