Skip to content

Allow string service tiers in config TOML#21697

Merged
aibrahim-oai merged 2 commits into
mainfrom
aibrahim/service-tier-config-string
May 8, 2026
Merged

Allow string service tiers in config TOML#21697
aibrahim-oai merged 2 commits into
mainfrom
aibrahim/service-tier-config-string

Conversation

@aibrahim-oai
Copy link
Copy Markdown
Collaborator

Why

service_tier in config.toml and profile config was still modeled as an enum, which blocked newer or experimental service tier IDs even though the runtime paths already carry string IDs.

This change makes the TOML-facing config accept string service tier IDs directly while keeping the legacy fast alias behavior by normalizing it to the request value priority.

What Changed

  • change the TOML-facing service_tier fields in global and profile config to Option<String>
  • keep config-load normalization so legacy fast still resolves to priority
  • persist resolved service tier strings directly in config locks so arbitrary IDs round-trip cleanly
  • regenerate the config schema and add config coverage for arbitrary string IDs plus legacy fast normalization

Verification

  • added config tests for arbitrary string service tiers and legacy fast normalization
  • ran just write-config-schema
  • CI

Accept arbitrary service tier IDs in config.toml and profile config while preserving legacy fast to priority normalization and config-lock round-tripping.

Co-authored-by: Codex <noreply@openai.com>
@aibrahim-oai aibrahim-oai requested a review from a team as a code owner May 8, 2026 08:18
Fix the new config tests by capturing cwd and codex_home before moving fixture.cfg.

Co-authored-by: Codex <noreply@openai.com>
@aibrahim-oai aibrahim-oai merged commit 317213f into main May 8, 2026
26 checks passed
@aibrahim-oai aibrahim-oai deleted the aibrahim/service-tier-config-string branch May 8, 2026 12:15
@github-actions github-actions Bot locked and limited conversation to collaborators May 8, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant