Allow string service tiers in config TOML#21697
Merged
Merged
Conversation
Accept arbitrary service tier IDs in config.toml and profile config while preserving legacy fast to priority normalization and config-lock round-tripping. Co-authored-by: Codex <noreply@openai.com>
Fix the new config tests by capturing cwd and codex_home before moving fixture.cfg. Co-authored-by: Codex <noreply@openai.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
service_tierinconfig.tomland profile config was still modeled as an enum, which blocked newer or experimental service tier IDs even though the runtime paths already carry string IDs.This change makes the TOML-facing config accept string service tier IDs directly while keeping the legacy
fastalias behavior by normalizing it to the request valuepriority.What Changed
service_tierfields in global and profile config toOption<String>faststill resolves topriorityfastnormalizationVerification
fastnormalizationjust write-config-schema