api: send hyphenated session and thread headers#21757
Merged
Merged
Conversation
aibrahim-oai
approved these changes
May 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Some consumers expect conventional hyphenated HTTP headers. Codex already sends the session and thread IDs on outbound Responses requests, but it only uses the underscore spellings today, which makes those IDs harder to consume in systems that normalize or reject underscore header names.
Full context here: https://openai.slack.com/archives/C08KCGLSPSQ/p1778248578422369
What changed
build_session_headersnow emits bothsession_idandsession-idwhen a session ID is present.thread_idandthread-id.codex-api/tests/clients.rsandcore/tests/suite/client.rsso both the lower-level client tests and the end-to-end request tests assert the two header spellings are present.Test plan
codex-api/tests/clients.rs.core/tests/suite/client.rsfor both the/v1/responsesand/api/codex/responsesrequest paths.