Make environment provider snapshots path-free#21794
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
💡 Codex Review
codex/codex-rs/exec-server/src/environment.rs
Line 669 in 2ae2034
from_provider_snapshot now inserts Arc::clone(&local_environment) for the reserved local id, so get_environment("local") and local_environment() intentionally point to the same Arc. This unchanged negative assertion will panic and fail the exec-server test suite whenever this test runs.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
d5e5617 to
c9f17aa
Compare
c9f17aa to
6ff4664
Compare
pakrym-oai
approved these changes
May 8, 2026
3f3d438 to
e978b79
Compare
e978b79 to
9515ace
Compare
9515ace to
7792a66
Compare
Make EnvironmentProvider snapshots path-free and keep providers focused on provider-owned remote environments. Providers can request local inclusion with include_local, while EnvironmentManager owns local environment construction from ExecServerRuntimePaths and injects the reserved local id when requested. Co-authored-by: Codex <noreply@openai.com>
7792a66 to
b35596b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to #20667
Testing