Skip to content

Increase exec-server environment transport timeouts#21825

Merged
starr-openai merged 3 commits into
mainfrom
starr/exec-env-timeouts-config-20260508
May 8, 2026
Merged

Increase exec-server environment transport timeouts#21825
starr-openai merged 3 commits into
mainfrom
starr/exec-env-timeouts-config-20260508

Conversation

@starr-openai
Copy link
Copy Markdown
Contributor

Why

The environment-backed exec-server transport currently hardcodes 5 second connect and initialize timeouts in client_transport.rs. That is short for SSH-backed stdio environments and remote websocket environments, and there is currently no way to raise those values from CODEX_HOME/environments.toml.

This stacked follow-up raises the default environment transport timeouts and lets each configured environment override them in environments.toml.

What Changed

  • raise the default environment transport connect and initialize timeouts from 5s to 10s
  • store concrete timeout values on ExecServerTransportParams instead of hardcoding them in connect_for_transport(...)
  • add connect_timeout_sec and initialize_timeout_sec to [[environments]] entries in environments.toml
  • apply parse-time defaults so runtime transport code receives fully resolved timeout values
  • reject connect_timeout_sec on stdio environments because it only applies to websocket transports
  • extend parser tests to cover the new fields and defaults

Stack

Validation

  • cd /Users/starr/code/codex-worktrees/exec-env-timeouts-config-20260508/codex-rs && just fmt
  • not run: tests

@starr-openai starr-openai requested a review from a team as a code owner May 8, 2026 21:04
@starr-openai starr-openai force-pushed the starr/exec-env-timeouts-config-20260508 branch from f27351a to bd9d772 Compare May 8, 2026 21:06
starr-openai added a commit that referenced this pull request May 8, 2026
Scope the new stdio transport helper to tests so Bazel clippy does not flag it as dead code on production targets.

Co-authored-by: Codex <noreply@openai.com>
@starr-openai starr-openai force-pushed the starr/local-env-provider-pr20667 branch 2 times, most recently from 7792a66 to b35596b Compare May 8, 2026 22:02
Base automatically changed from starr/local-env-provider-pr20667 to main May 8, 2026 22:30
starr-openai and others added 2 commits May 8, 2026 15:31
Add connect/initialize timeout settings to environment transports, raise the default environment transport timeouts from 5s to 10s, and make the values configurable through CODEX_HOME/environments.toml.

Co-authored-by: Codex <noreply@openai.com>
Scope the new stdio transport helper to tests so Bazel clippy does not flag it as dead code on production targets.

Co-authored-by: Codex <noreply@openai.com>
@starr-openai starr-openai force-pushed the starr/exec-env-timeouts-config-20260508 branch from b82e2e4 to 388ed85 Compare May 8, 2026 22:32
Co-authored-by: Codex <noreply@openai.com>
@starr-openai starr-openai merged commit faa5d4a into main May 8, 2026
35 of 38 checks passed
@starr-openai starr-openai deleted the starr/exec-env-timeouts-config-20260508 branch May 8, 2026 23:33
@github-actions github-actions Bot locked and limited conversation to collaborators May 8, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants