fix(tui): improve light-mode selection contrast#21950
Merged
Merged
Conversation
etraut-openai
approved these changes
May 9, 2026
Collaborator
etraut-openai
left a comment
There was a problem hiding this comment.
Looks good! I was able to repro the bug on iTerm2 with a light theme, and I confirmed that the fix addresses the problem.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
On light terminal backgrounds, selected rows in several TUI pickers were rendered with the same bright cyan accent used on dark themes. Against the light menu surface, that made the current selection hard to distinguish at a glance.
Before
After
What changed
How to Test
/to open the slash-command picker and move the selection through a few rows./keymapand confirm the active tab, selected rows, and picker hint accents use the same light-theme accent treatment.Targeted tests:
cargo test -p codex-tui accent_style_uses_cargo test -p codex-tui selected_rows_use_the_shared_accent_stylecargo test -p codex-tui selected_event_rows_use_the_shared_accent_styleNotes:
cargo test -p codex-tuirun reached the end of the suite but hit an unrelated existing stack overflow intests::fork_last_filters_latest_session_by_cwd_unless_show_all.