Refactor chatwidget input flow into modules#22407
Merged
Merged
Conversation
canvrno-oai
approved these changes
May 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
chatwidget.rsis still carrying too many unrelated responsibilities in one file. #22269 started a five-phase effort to move coherent behavior domains into focused modules while keepingchatwidget.rsas the composition layer.This PR is phase 2 of that plan. It extracts the input and submission flow as a mechanical move before the later protocol, popup/status, and constructor/orchestration phases.
What Changed
codex-rs/tui/src/chatwidget/input_flow.rsfor composer input results, queued user-message draining, pending-input previews, and mode-specific submission entry points.codex-rs/tui/src/chatwidget/input_submission.rsfor user-message construction/submission, shell prompt submission, structured mention resolution, and blocked image draft restoration.codex-rs/tui/src/chatwidget/input_restore.rsfor initial-message submission, pending steer restoration after interrupts, and thread input snapshot/restore behavior.ChatWidgetimpl methods fromcodex-rs/tui/src/chatwidget.rs.Follow-On Refactor Phases
The five-phase plan from #22269 is:
chatwidget.rsas the composition layer.