[codex] Add installed-plugin mention API by xli-oai · Pull Request #22448 · openai/codex

xli-oai · 2026-05-13T07:07:48Z

Summary

add app-server plugin/installed for mention-oriented plugin loading
return installed plugins plus explicitly requested install-suggestion rows
keep remote handling on installed-state data instead of the broad catalog listing path

Why

The @ mention surface only needs plugins that are usable now, plus a small product-approved set of install suggestions. It does not need the full catalog-shaped plugin/list payload that the Plugins page uses.

Validation

just write-app-server-schema
just fmt
cargo test -p codex-app-server-protocol
cargo test -p codex-core-plugins
cargo test -p codex-app-server --test all plugin_installed_

Notes

The package-wide cargo test -p codex-app-server run still hits an existing unrelated stack overflow in in_process::tests::in_process_start_clamps_zero_channel_capacity.
Companion webview PR: https://github.com/openai/openai/pull/915672

Stacked on #22448. This moves the broader follow-up behavior out of the parent PR so the parent stays focused on the `plugin/installed` mention-list API. Changes: - Start remote installed bundle sync from `plugin/installed`. - Pass request-processor remote scopes into the bundle sync path. - Include remote installed scopes in effective plugin load cache handling. - Keep the bundle sync coverage in this child PR instead of the parent. Validation: - `cargo check -p codex-core-plugins` - `cargo check -p codex-app-server` - `cargo test -p codex-core-plugins remote_installed_plugin` - `env RUST_MIN_STACK=16777216 cargo test -p codex-app-server --test all plugin_installed_` - `just fix -p codex-core-plugins` - `just fix -p codex-app-server`

xli-oai · 2026-05-16T11:12:55Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: ed7215b552

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

xli-oai · 2026-05-18T04:04:41Z

@codex review

chatgpt-codex-connector

💡 Codex Review

codex/codex-rs/core-plugins/src/remote/remote_installed_plugin_sync.rs

Lines 94 to 98 in f6d54f5

    
           let key = RemoteInstalledPluginBundleSyncKey { 
        
               plugin_cache_root: remote_plugin_cache_root(&codex_home), 
        
           }; 
        
           if !mark_remote_installed_plugin_bundle_sync_in_flight(key.clone()) { 
        
               return;

Deduplicate bundle syncs by requested scope

Now that bundle sync can be scoped, the in-flight guard still keys only by cache root. If a Global-only sync is running (for example from startup or plugin/list) and plugin/installed requests Workspace before it finishes, this returns early and drops the workspace sync entirely; the workspace metadata may be cached, but its local bundle is never downloaded until another later trigger.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

xli-oai · 2026-05-18T06:37:23Z

@codex review

chatgpt-codex-connector

💡 Codex Review

codex/codex-rs/core-plugins/src/remote/remote_installed_plugin_sync.rs

Lines 94 to 98 in 22e42ee

    
           let key = RemoteInstalledPluginBundleSyncKey { 
        
               plugin_cache_root: remote_plugin_cache_root(&codex_home), 
        
           }; 
        
           if !mark_remote_installed_plugin_bundle_sync_in_flight(key.clone()) { 
        
               return;

Include scopes when de-duping bundle syncs

With the new scoped bundle sync, the in-flight key still only includes the cache root. If a global-only sync is already running and a workspace-scoped plugin/installed or plugin-list refresh arrives, mark_remote_installed_plugin_bundle_sync_in_flight returns false and the workspace sync is dropped rather than queued or merged, so workspace installed plugin bundles may never be downloaded until some later unrelated trigger. The de-dupe key or scheduler needs to account for requested scopes.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

xli-oai · 2026-05-18T08:33:38Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 4dbcac0e39

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

xli-oai added the oai PRs contributed by OpenAI employees label May 13, 2026 — with ChatGPT Codex Connector

This was referenced May 15, 2026

📊 AI CLI 工具社区动态日报 2026-05-15 gsscsd/big_model_radar#346

Open

📊 AI CLI 工具社区动态日报 2026-05-15 ivanweng2077/big_model_radar#45

Open

xli-oai added 5 commits May 14, 2026 20:40

Add plugin installed app-server mentions path

9613308

Use cached remote plugins for installed mentions

0faa4a0

Render installed plugin mentions from cache

0f5e031

Clarify installed plugin response helpers

a0d305a

Use explicit conversion helper names

5b08045

xli-oai force-pushed the xli-codex/plugin-installed-mentions branch 2 times, most recently from a5cba27 to 5b08045 Compare May 15, 2026 03:53

xli-oai added 20 commits May 14, 2026 21:36

Reuse marketplace listing for installed plugins

38dd15b

Remove remote installed marketplace fetcher

bd7b57a

Reuse plugin marketplace conversion helper

b558285

Use cached remote installed state for mentions

9bc1f2d

Restore remote installed plugin fallback

1ff7845

Remove remote catalog gate from installed plugins

d17ee5e

Split installed plugin response helpers

bf71006

Inline installed plugin preconditions

94eb16a

Rename suggested plugin helper

8c169f2

Clarify remote installed plugin projection names

40b7b62

Clarify remote installed plugin grouping

cd37674

Tidy remote installed plugin grouping

18249d4

Rename remote installed marketplace fetch helper

2eb4afd

Clarify remote installed cache build helpers

d723576

Use remote metadata for installed plugin mentions

7efc049

Trim remote installed plugin cache fields

fb1abb5

Combine local installed plugin listing

5c136e4

Rename remote installed plugin cache mapper

de49d76

Remove marketplace plugin filter parameter

510e886

Tidy remote installed marketplace grouping

4064ad2

xli-oai added 2 commits May 15, 2026 23:39

Move remote installed scope gating to app-server

252361e

codex: narrow plugin installed mentions change

9997f00

xli-oai mentioned this pull request May 16, 2026

Scope remote installed sync for plugin installed mentions #22978

Merged

xli-oai added 3 commits May 16, 2026 02:04

codex: simplify remote installed scope caching

61bb922

codex: remove remote installed fetch wrapper

ed7215b

chatgpt-codex-connector Bot reviewed May 16, 2026

View reviewed changes

codex: do not serialize plugin installed requests

f6d54f5

This was referenced May 17, 2026

📊 AI CLI 工具社区动态日报 2026-05-17 zx0828/big_model_radar#60

Open

📊 AI CLI 工具社区动态日报 2026-05-17 gsscsd/big_model_radar#356

Open

chatgpt-codex-connector Bot reviewed May 18, 2026

View reviewed changes

Comment thread codex-rs/core-plugins/src/manager.rs Outdated

Comment thread codex-rs/core-plugins/src/remote/remote_installed_plugin_sync.rs Outdated

Comment thread codex-rs/core-plugins/src/manager.rs Outdated

xli-oai added 2 commits May 17, 2026 22:37

codex: include plugin sharing in remote installed scopes

4b529ef

codex: track remote installed cache scopes

22e42ee

chatgpt-codex-connector Bot reviewed May 18, 2026

View reviewed changes

Comment thread codex-rs/core-plugins/src/manager.rs Outdated

codex: keep remote bundle sync unscoped

abde2ca

xli-oai added a commit that referenced this pull request May 18, 2026

codex: address PR review feedback (#22448)

e485f27

xli-oai force-pushed the xli-codex/plugin-installed-mentions branch from e485f27 to abde2ca Compare May 18, 2026 07:17

xli-oai added 4 commits May 18, 2026 00:24

codex: restore explicit remote cache cleanup loop

1ffdbd5

codex: keep remote installed refresh unscoped

17864b9

codex: inline installed plugin helper tuple

15cd5ac

codex: filter installed remote marketplaces by feature

4dbcac0

chatgpt-codex-connector Bot reviewed May 18, 2026

View reviewed changes

Comment thread codex-rs/app-server/src/request_processors/plugins.rs

Comment thread codex-rs/core-plugins/src/manager.rs

Comment thread codex-rs/app-server/src/request_processors/plugins.rs

xli-oai force-pushed the xli-codex/plugin-installed-mentions branch from 9c41618 to 4dbcac0 Compare May 18, 2026 09:56

xli-oai merged commit da14dd2 into main May 18, 2026
77 of 78 checks passed

xli-oai deleted the xli-codex/plugin-installed-mentions branch May 18, 2026 10:11

github-actions Bot locked and limited conversation to collaborators May 18, 2026

	let key = RemoteInstalledPluginBundleSyncKey {
	plugin_cache_root: remote_plugin_cache_root(&codex_home),
	};
	if !mark_remote_installed_plugin_bundle_sync_in_flight(key.clone()) {
	return;

Conversation

xli-oai commented May 13, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Why

Validation

Notes

Uh oh!

xli-oai commented May 16, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

xli-oai commented May 18, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

Uh oh!

xli-oai commented May 18, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

xli-oai commented May 18, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

xli-oai commented May 13, 2026 •

edited

Loading