Skip to content

Fix abort-path turn extension data plumbing#22646

Merged
jif-oai merged 1 commit into
mainfrom
jif/fix-turn-extension-data
May 14, 2026
Merged

Fix abort-path turn extension data plumbing#22646
jif-oai merged 1 commit into
mainfrom
jif/fix-turn-extension-data

Conversation

@jif-oai
Copy link
Copy Markdown
Collaborator

@jif-oai jif-oai commented May 14, 2026

Why

SessionTaskContext carries the current turn's ExtensionData so task runners and cleanup code can use the same turn-scoped extension store. The normal run path builds that context before spawning the task, but abort handling has to rebuild it later from the saved RunningTask.

Preserving the turn's ExtensionData on RunningTask keeps the abort path aligned with the run path instead of losing the turn-scoped extension state during cancellation cleanup.

What Changed

  • Store the turn's ExtensionData on RunningTask and use it when rebuilding SessionTaskContext during task abort handling.
  • Update direct test ExtensionData::new(...) call sites to pass the turn id expected by the current constructor.

Testing

  • Not run locally after creating the PR branch.

@jif-oai jif-oai requested a review from a team as a code owner May 14, 2026 13:52
@jif-oai
Copy link
Copy Markdown
Collaborator Author

jif-oai commented May 14, 2026

@codex review

@chatgpt-codex-connector
Copy link
Copy Markdown
Contributor

Codex Review: Didn't find any major issues. 👍

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@jif-oai jif-oai merged commit 12bfb57 into main May 14, 2026
29 checks passed
@jif-oai jif-oai deleted the jif/fix-turn-extension-data branch May 14, 2026 14:00
@github-actions github-actions Bot locked and limited conversation to collaborators May 14, 2026
@jif-oai jif-oai changed the title Fix turn extension data task plumbing Fix abort-path turn extension data plumbing May 14, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant