Conversation
This was referenced May 15, 2026
viyatb-oai
approved these changes
May 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
SandboxPolicyis being pushed back toward legacy config loading and compatibility boundaries. Guardian review sessions already want the built-in read-only permission behavior; carrying that as an activePermissionProfilemakes the review sandbox follow the new permissions path instead of configuring the child session through the legacy policy API.What Changed
PermissionProfile::read_only().Op::UserTurn.sandbox_policyfield populated withSandboxPolicy::new_read_only_policy()declared next to the profile so the two remain visibly in sync until the compatibility field goes away.How To Review
Start in
codex-rs/core/src/guardian/review_session.rs. The important check is that both the guardian config and the child turn now use the read-only permission profile, while the remainingSandboxPolicy::ReadOnlyassignment is only the compatibility field required by the current turn protocol.Verification
cargo test -p codex-core guardian_review_session_config_clears_parent_developer_instructionsStack created with Sapling. Best reviewed with ReviewStack.