Ignore configured hooks in git helpers#22843
Merged
Merged
Conversation
evawong-oai
approved these changes
May 15, 2026
Contributor
evawong-oai
left a comment
There was a problem hiding this comment.
Approved with Windows validation for current head a277b38.
I validated this on the persistent Windows Codex validation VM. I am omitting VM instance details here.
- Current PR head matched a277b38.
- Git utils crate tests passed. 21 passed, 0 failed.
- Core filtered has changes tests passed. 4 passed, 0 failed.
- Manual Windows hook repro used a real hook executable under repository configured core.hooksPath.
- Baseline without the NUL override fired the hook. BASELINE_HOOK_FIRED=True.
- With core.hooksPath=NUL, both marker checks stayed false. FIXED_MARKER_BASE=False. FIXED_MARKER_ENV=False.
- Verdict: the PR blocks the validated Windows Git helper hook primitive on this head.
Evidence is preserved under C:\CodexValidation.
jif-oai
approved these changes
May 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Why
How
core.hooksPathoverride in the shared helper path and the Git-info helper path.Validation
cargo fmt --manifest-path /Users/bookholt/code/codex/codex-rs/Cargo.toml --all --checkcargo test --manifest-path /Users/bookholt/code/codex/codex-rs/Cargo.toml -p codex-git-utilscargo test --manifest-path /Users/bookholt/code/codex/codex-rs/Cargo.toml -p codex-core test_get_has_changes_