fix: harden plugin creator sharing validation#22893
Merged
Merged
Conversation
8330cde to
80d9c99
Compare
xl-openai
reviewed
May 15, 2026
| - Personal plugin: `~/.agents/plugins/marketplace.json` | ||
| - Repo/team plugin: `<repo-root>/.agents/plugins/marketplace.json` | ||
|
|
||
| ### Workspace sharing notes |
Collaborator
There was a problem hiding this comment.
Maybe we should treat this as a general guidance, not just for sharing?
xl-openai
approved these changes
May 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Before this change, the sample plugin creator could emit placeholder-heavy manifests that fail workspace sharing, and it chose a repo-local marketplace implicitly whenever it ran from inside a git checkout.
This PR makes generated plugins share-ready by default. It switches creation to the personal marketplace unless the caller explicitly opts into repo-local paths, adds a validator that mirrors the workspace plugin ingestion contract, and updates the skill prompt and docs to describe the real flow.
The goal is to stop malformed generated plugins before they reach sharing and to make the default placement match the personal marketplace behavior users expect.
Changes
[TODO: ...]placeholder payloads.~/pluginsand~/.agents/plugins/marketplace.json.--pathand--marketplace-patharguments.validate_plugin.pyto check manifests, companion files, skill frontmatter, skill agent YAML, asset paths, and backend-shaped contracts before sharing.Design decisions
defaultPromptalias handling and skillagents/openai.yamlchecks.[TODO: ...]placeholders are rejected before sharing even when a single placeholder would not independently violate backend type validation.Testing
Tests: targeted Python syntax checks, plugin skill validation, staged diff whitespace validation, 15 generated plugin smoke runs, backend manifest-schema acceptance for all 15 generated bundles, and a git-repo cwd regression proving the creator still writes to the personal marketplace by default.