Skip to content

Make multi-agent v2 tool namespace configurable#23147

Merged
jif-oai merged 2 commits into
mainfrom
jif/multi-agent-v2-tool-namespace
May 17, 2026
Merged

Make multi-agent v2 tool namespace configurable#23147
jif-oai merged 2 commits into
mainfrom
jif/multi-agent-v2-tool-namespace

Conversation

@jif-oai
Copy link
Copy Markdown
Collaborator

@jif-oai jif-oai commented May 17, 2026

Summary

  • Add features.multi_agent_v2.tool_namespace with config/schema validation for Responses-compatible namespace values.
  • Thread the resolved namespace into ToolsConfig for normal turns and review turns.
  • Wrap MultiAgentV2 tool specs and registry names in the configured namespace when namespace tools are supported, while falling back to the plain tool names when they are not.

Validation

  • just fmt
  • just write-config-schema
  • cargo test -p codex-features multi_agent_v2_feature_config -- --nocapture
  • cargo test -p codex-core test_build_specs_multi_agent_v2 -- --nocapture
  • cargo test -p codex-core multi_agent_v2_config -- --nocapture
  • cargo test -p codex-core multi_agent_v2_rejects_invalid_tool_namespace -- --nocapture
  • cargo test -p codex-tools
  • git diff --check

@jif-oai jif-oai marked this pull request as ready for review May 17, 2026 12:48
@jif-oai jif-oai requested a review from a team as a code owner May 17, 2026 12:48
@jif-oai
Copy link
Copy Markdown
Collaborator Author

jif-oai commented May 17, 2026

@codex review

Copy link
Copy Markdown
Contributor

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 1a4496e6cd

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread codex-rs/core/src/tools/spec_plan.rs
Comment thread codex-rs/core/src/tools/spec_plan.rs
@jif-oai
Copy link
Copy Markdown
Collaborator Author

jif-oai commented May 17, 2026

@codex review

Copy link
Copy Markdown
Contributor

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 77ae0fa4ec

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread codex-rs/core/src/config/mod.rs
@jif-oai jif-oai enabled auto-merge (squash) May 17, 2026 13:22
@jif-oai jif-oai disabled auto-merge May 17, 2026 13:27
@jif-oai jif-oai merged commit 545ede5 into main May 17, 2026
30 checks passed
@jif-oai jif-oai deleted the jif/multi-agent-v2-tool-namespace branch May 17, 2026 13:27
@github-actions github-actions Bot locked and limited conversation to collaborators May 17, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants