add encryptedcontent to functioncalloutput#23500
Conversation
sayan-oai
force-pushed
the
dev/sayan/encrypted-fn-output
branch
from
be4776d to
72d06cf
Compare
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: be4776db4b
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
@codex review this |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 48f2ddda7f
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| FunctionCallOutputContentItem::EncryptedContent { encrypted_content } => { | ||
| out.push(FunctionCallOutputContentItem::EncryptedContent { | ||
| encrypted_content: encrypted_content.clone(), | ||
| }); |
There was a problem hiding this comment.
When a tool returns a large encrypted_content item, this new arm copies the whole blob even though truncate_function_output_items_with_policy is the path used by core/src/context_manager/history.rs to trim function-call outputs before they are kept/replayed in model context. Text output consumes remaining_budget, but encrypted content is now an unbounded model-context item; standalone web search payloads can easily exceed the >1k-token manual-review threshold from .codex/skills/code-review-context/SKILL.md and can push requests over context/API limits. Please apply a hard cap or route these opaque blobs through a bounded/non-context path instead of preserving them unconditionally.
Useful? React with 👍 / 👎.
2 participants
add new
EncryptedContentvariant toFunctionCallOutputContentItemahead of standalone websearch.we need to be able to receive and pass encrypted function call output from the new web search endpoint back to responsesapi, as we cannot expose direct search results.