Skip to content

fix(config): resolve cloud requirements deny-read globs#23729

Merged
viyatb-oai merged 1 commit into
mainfrom
codex/viyatb/fix-cloud-requirements-deny-read-globs
May 20, 2026
Merged

fix(config): resolve cloud requirements deny-read globs#23729
viyatb-oai merged 1 commit into
mainfrom
codex/viyatb/fix-cloud-requirements-deny-read-globs

Conversation

@viyatb-oai
Copy link
Copy Markdown
Collaborator

@viyatb-oai viyatb-oai commented May 20, 2026

Why

Cloud-managed requirements.toml contents were deserialized without an AbsolutePathBuf base directory. Relative managed permissions.filesystem.deny_read glob entries therefore failed while the equivalent local system requirements path succeeded under its AbsolutePathBufGuard. This follows the codex_home base path convention clarified in #15707.

What changed

  • Resolve cloud requirements TOML under an AbsolutePathBufGuard rooted at codex_home.
  • Reuse the same base for cloud requirements loaded from the signed cache.
  • Add a regression test for a relative cloud-managed deny_read glob.

Validation

  • just fmt
  • cargo test -p codex-cloud-requirements
  • cargo clippy -p codex-cloud-requirements --all-targets --no-deps
  • just bazel-lock-update
  • just bazel-lock-check
  • git diff --check

Co-authored-by: Codex noreply@openai.com
@viyatb-oai viyatb-oai marked this pull request as ready for review May 20, 2026 18:58
@viyatb-oai viyatb-oai requested a review from bolinfest May 20, 2026 18:59
@viyatb-oai viyatb-oai merged commit 0edcc4b into main May 20, 2026
31 checks passed
@viyatb-oai viyatb-oai deleted the codex/viyatb/fix-cloud-requirements-deny-read-globs branch May 20, 2026 19:15
@github-actions github-actions Bot locked and limited conversation to collaborators May 20, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants