Skip to content

fix(auto-review) skip legacy notify for auto review threads#24714

Merged
dylan-hurd-oai merged 1 commit into
mainfrom
codex/guardian-skip-legacy-notify
May 27, 2026
Merged

fix(auto-review) skip legacy notify for auto review threads#24714
dylan-hurd-oai merged 1 commit into
mainfrom
codex/guardian-skip-legacy-notify

Conversation

@dylan-hurd-oai
Copy link
Copy Markdown
Collaborator

@dylan-hurd-oai dylan-hurd-oai commented May 27, 2026

Summary

Clear inherited legacy notify from Guardian review session config, since we should not be passing auto review threads into notify targets. Keeps legacy notify payload and hook runtime behavior unchanged for normal user turns.

Testing

  • add a Guardian config regression and dedicated Guardian integration test so review sessions cannot inherit parent notify hooks

@dylan-hurd-oai dylan-hurd-oai requested a review from a team as a code owner May 27, 2026 05:48
Comment thread codex-rs/core/src/hook_runtime.rs Outdated
@dylan-hurd-oai dylan-hurd-oai force-pushed the codex/guardian-skip-legacy-notify branch from 2b0716b to ca19fa5 Compare May 27, 2026 06:24
@dylan-hurd-oai dylan-hurd-oai force-pushed the codex/guardian-skip-legacy-notify branch from ca19fa5 to b96b246 Compare May 27, 2026 06:32
Copy link
Copy Markdown
Collaborator

@etraut-openai etraut-openai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@dylan-hurd-oai dylan-hurd-oai changed the title Skip legacy notify for Guardian review threads fix(auto-review) skip legacy notify for auto review threads May 27, 2026
@dylan-hurd-oai dylan-hurd-oai enabled auto-merge (squash) May 27, 2026 07:19
@dylan-hurd-oai dylan-hurd-oai merged commit e886266 into main May 27, 2026
46 of 47 checks passed
@dylan-hurd-oai dylan-hurd-oai deleted the codex/guardian-skip-legacy-notify branch May 27, 2026 07:23
@github-actions github-actions Bot locked and limited conversation to collaborators May 27, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants