Add exec output-schema parameter#4079
Conversation
# Conflicts: # codex-rs/core/tests/common/Cargo.toml
… and schema validation
|
@codex review this |
|
Codex Review: Didn't find any major issues. 👍 About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you open a pull request for review, mark a draft as ready, or comment "@codex review". If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex fix this CI failure" or "@codex address that feedback". |
aibrahim-oai
left a comment
aibrahim-oai
left a comment
There was a problem hiding this comment.
There are some unrelated changes that would be best in a different PR. Some comments about the test assertion. Beside this, awesome work!
| Some(&serde_json::Value::String("json_schema".into())) | ||
| ); | ||
| assert_eq!(format.get("strict"), Some(&serde_json::Value::Bool(true))); | ||
| assert_eq!(format.get("schema"), Some(&schema)); |
There was a problem hiding this comment.
wdut about serializing it and having one assert_eq function.
There was a problem hiding this comment.
I'd rather have detailed asserts here. Will assert the entire thing in exec tests.
…schema-parameter # Conflicts: # codex-rs/core/src/codex/compact.rs
exec/tests/suite/output_schema.rs: refactor to build schema with serde_json, write as pretty json, and assert full format object equality
2 participants
Adds structured output to
execvia the--structured-outputparameter.