Conversation
pakrym-oai
reviewed
Sep 25, 2025
pakrym-oai
reviewed
Sep 25, 2025
| } | ||
|
|
||
| enum RetryDirective { | ||
| Http { |
Collaborator
There was a problem hiding this comment.
This feels like an error type
Collaborator
Author
|
changed the function to return |
pakrym-oai
approved these changes
Sep 25, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I would like to be able to swap in a different way to resolve model sampling requests, so this refactoring consolidates things behind
attempt_stream_responses()to make that easier. Ideally, we would support an in-memory backend that we can use in our integration tests, for example.