fix#4251
Merged
aibrahim-oai merged 4 commits intomainfrom Sep 25, 2025
Merged
Conversation
pakrym-oai
reviewed
Sep 25, 2025
| used_percent, | ||
| window_minutes: parse_header_u64(headers, window_minutes_header), | ||
| resets_in_seconds: parse_header_u64(headers, resets_header), | ||
| used_percent.and_then(|used_percent| { |
Collaborator
There was a problem hiding this comment.
why so complicated? why not parse all 3 into variables and then have
match (used_percent, window_minutes, resets_in_seconds) =>
(Some, some, some) => Some()
=> None
Collaborator
Author
There was a problem hiding this comment.
We send the headers as 0 when limits aren't set.
pakrym-oai
approved these changes
Sep 25, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
External (non-OpenAI) Pull Request Requirements
Before opening this Pull Request, please read the dedicated "Contributing" markdown file or your PR may be closed:
https://github.com/openai/codex/blob/main/docs/contributing.md
If your PR conforms to our contribution guidelines, replace this text with a detailed and high quality description of your changes.