Skip to content

Add codex exec testing helpers#4254

Merged
pakrym-oai merged 2 commits intomainfrom
pakrym/add-codex-exec-testing-helpers
Sep 26, 2025
Merged

Add codex exec testing helpers#4254
pakrym-oai merged 2 commits intomainfrom
pakrym/add-codex-exec-testing-helpers

Conversation

@pakrym-oai
Copy link
Copy Markdown
Collaborator

Add a shortcut to create working directories and run codex exec with fake server.

exec/tests: update suite tests to use TestCodexExecBuilder's internal cwd and home path methods, removing need for build() and accessing temp paths directly
Copy link
Copy Markdown
Contributor

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting

Comment on lines +12 to +14
pub fn cmd(&self) -> assert_cmd::Command {
let mut cmd = assert_cmd::Command::cargo_bin("codex-exec")
.expect("should find binary for codex-exec");
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Import assert_cmd cargo helpers

TestCodexExecBuilder::cmd calls assert_cmd::Command::cargo_bin, but the file never brings CommandCargoExt from assert_cmd::prelude into scope. Because cargo_bin is an extension trait method, the helper and any tests using it will fail to compile. Import the prelude or invoke the method with an explicit trait path.

Useful? React with 👍 / 👎.

@pakrym-oai pakrym-oai merged commit 8e3a048 into main Sep 26, 2025
19 checks passed
@pakrym-oai pakrym-oai deleted the pakrym/add-codex-exec-testing-helpers branch September 26, 2025 00:12
@github-actions github-actions Bot locked and limited conversation to collaborators Sep 26, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants