Add codex exec testing helpers#4254
Conversation
exec/tests: update suite tests to use TestCodexExecBuilder's internal cwd and home path methods, removing need for build() and accessing temp paths directly
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting
| pub fn cmd(&self) -> assert_cmd::Command { | ||
| let mut cmd = assert_cmd::Command::cargo_bin("codex-exec") | ||
| .expect("should find binary for codex-exec"); |
There was a problem hiding this comment.
Import assert_cmd cargo helpers
TestCodexExecBuilder::cmd calls assert_cmd::Command::cargo_bin, but the file never brings CommandCargoExt from assert_cmd::prelude into scope. Because cargo_bin is an extension trait method, the helper and any tests using it will fail to compile. Import the prelude or invoke the method with an explicit trait path.
Useful? React with 👍 / 👎.
Add a shortcut to create working directories and run codex exec with fake server.