Misc SDK fixes#4752
Merged
pakrym-oai merged 4 commits intomainfrom Oct 5, 2025
Merged
Conversation
…and error handling boilerplate in README.md
bolinfest
approved these changes
Oct 5, 2025
| ``` | ||
|
|
||
| To avoid unrecoverable errors, Codex requires the working directory to be a git repository. You can skip the git repository check by passing the `skipGitRepoCheck` option to the when creating a thread. | ||
| To avoid unrecoverable errors, Codex requires the working directory to be a git repository. You can skip the git repository check by passing the `skipGitRepoCheck` option when creating a thread. |
Collaborator
There was a problem hiding this comment.
Git should be capitalized when saying "Git repository," I believe.
| } finally { | ||
| await close(); | ||
| } | ||
| }, 10000); // TODO(pakrym): remove timeout |
Collaborator
There was a problem hiding this comment.
protip: 10_000
can we at least make the timeout smaller for now?
Collaborator
Author
There was a problem hiding this comment.
Takes 6 seconds to finish :(
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove codex-level workingDirectory
Throw on turn.failed in
run()Cleanup readme