Use wait_for_event helpers in tests by pakrym-oai · Pull Request #4753 · openai/codex

pakrym-oai · 2025-10-05T02:47:42Z

Summary

replace manual event polling loops in several core test suites with the shared wait_for_event helpers
keep prior assertions intact by using closure captures for stateful expectations, including plan updates, patch lifecycles, and review flow checks
rely on wait_for_event_with_timeout where longer waits are required, simplifying timeout handling

Use wait_for_event helpers in tests

5fa75ef

pakrym-oai added the codex Label used by connector to tag PRs that have been reviewed by Codex label Oct 5, 2025 — with ChatGPT Codex Connector

aibrahim-oai approved these changes Oct 5, 2025

View reviewed changes

pakrym-oai merged commit 06853d9 into main Oct 5, 2025
20 checks passed

pakrym-oai deleted the codex/replace-loops-with-wait_for_event-calls branch October 5, 2025 05:04

github-actions Bot locked and limited conversation to collaborators Oct 5, 2025