Make output assertions more explicit#4784
Merged
pakrym-oai merged 2 commits intomainfrom Oct 5, 2025
Merged
Conversation
pakrym-oai
commented
Oct 5, 2025
Comment on lines
+516
to
+518
| Total output lines: \d+ | ||
| Output: | ||
| Total output lines: \d+ |
Collaborator
Author
There was a problem hiding this comment.
@aibrahim-oai this is why I wanted full string matches.
dylan-hurd-oai
approved these changes
Oct 5, 2025
Collaborator
dylan-hurd-oai
left a comment
dylan-hurd-oai
left a comment
There was a problem hiding this comment.
LGTM, thank you!
aibrahim-oai
approved these changes
Oct 5, 2025
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting
- Change regex patterns from raw string (r"...") to raw string with preferred delimiter (r#"..."#) for correct pattern escaping and minimize backslash confusion. - Update sandbox and spawn error output checks to be more robust by handling both new and fallback matching cases. - Ensure test consistency and reliability for shell output truncation and error message patterns.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Match using precise regexes.