Trim double Total output lines#4787
Conversation
- Add regex patterns for outputs including exit code, wall time, and total output lines - Allow matching of both new and legacy error output formats - Fallback to previous error pattern if new patterns fail - Strengthen test robustness for spawn failure output
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting
| Wall time: [0-9]+(?:\.[0-9]+)? seconds | ||
| Total output lines: \d+ | ||
| Output: | ||
| Total output lines: \d+ | ||
|
|
||
| failed in sandbox: .*?(?:Operation not permitted|Permission denied|Read-only file system).*? |
There was a problem hiding this comment.
The structured output now strips the Total output lines header and its separating blank line, so the output string begins immediately after Output:. The regex here still contains an empty line between Output: and the first expected message, which means shell_sandbox_denied_truncates_error_output will fail once the new formatting is produced. Drop the blank line or make it optional so the pattern matches the updated output.
Useful? React with 👍 / 👎.
| Wall time: [0-9]+(?:\.[0-9]+)? seconds | ||
| Total output lines: \d+ | ||
| Output: | ||
| Total output lines: \d+ | ||
|
|
||
| execution error: .*$"#; |
There was a problem hiding this comment.
Similar to the previous test, build_structured_output now removes the truncation header from the embedded output, eliminating the blank line that used to follow Output:. The spawn_truncated_pattern still includes an empty line in the regex, so it will no longer match the formatted output and will cause the test to fail. Adjust the pattern to expect Output: followed immediately by the error text (or make the extra newline optional).
Useful? React with 👍 / 👎.
|
2 participants
No description provided.