Skip to content

bug: sandbox denied error logs#4874

Merged
jif-oai merged 14 commits intomainfrom
jif/sanbox-error-lofs
Oct 9, 2025
Merged

bug: sandbox denied error logs#4874
jif-oai merged 14 commits intomainfrom
jif/sanbox-error-lofs

Conversation

@jif-oai
Copy link
Copy Markdown
Collaborator

@jif-oai jif-oai commented Oct 7, 2025

Check on STDOUT / STDERR or aggregated output for some logs when sanbox is denied

Comment thread codex-rs/core/src/error.rs Outdated
Comment thread codex-rs/core/src/exec.rs Outdated
@jif-oai
Copy link
Copy Markdown
Collaborator Author

jif-oai commented Oct 8, 2025

@codex fix the tests

@chatgpt-codex-connector
Copy link
Copy Markdown
Contributor

Summary

  • Updated sandbox denied UI messaging to combine stdout and stderr when aggregated text is missing, added explicit stdout-only coverage, and expanded regression tests for the sandbox error message helper. codex-rs/core/src/error.rsL310-L441
  • Simplified sandbox denial keyword scanning to check stdout, stderr, and aggregated streams individually without building an intermediate joined buffer. codex-rs/core/src/exec.rsL200-L233

Testing

  • ⚠️ cargo test -p codex-core (fails: unable to download crates from crates.io in the sandbox).
  • ⚠️ cargo test -p codex-core --offline (fails: cargo still needs the tree-sitter crate while offline).
  • ⚠️ just fix -p codex-core (fails: crate download blocked in the sandbox).

View task →

Comment thread codex-rs/core/src/exec.rs
Comment thread codex-rs/core/src/exec.rs Outdated
@jif-oai jif-oai enabled auto-merge (squash) October 9, 2025 15:44
@jif-oai jif-oai merged commit ca6a035 into main Oct 9, 2025
20 checks passed
@jif-oai jif-oai deleted the jif/sanbox-error-lofs branch October 9, 2025 16:01
@github-actions github-actions Bot locked and limited conversation to collaborators Oct 9, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants