Conversation
Collaborator
gpeal
commented
Oct 7, 2025
- You can now add streamable http servers via the CLI
- As part of this, I'm also changing the existing bearer_token plain text config field with ane env var
Contributor
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting
bolinfest
approved these changes
Oct 8, 2025
| } | ||
|
|
||
| #[derive(Debug, clap::Args)] | ||
| #[command( |
Collaborator
There was a problem hiding this comment.
This doesn't look right to me. Chat suggested:
#[derive(Debug, clap::Args)]
pub struct AddMcpTransportArgs {
#[command(flatten)]
#[group(required = true, multiple = false, name = "transport")]
pub stdio: Option<AddMcpStdioArgs>,
#[command(flatten)]
#[group(name = "transport")]
pub streamable_http: Option<AddMcpStreamableHttpArgs>,
}
Collaborator
Author
There was a problem hiding this comment.
Clap is a bit finicky to work with but I wrote unit tests to verify the failure and this change breaks a couple of them.
…tions-with-oauth-store
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.