Revert "Revert "Overhaul shell detection and centralize command generation for unified exec""#6607
Merged
pakrym-oai merged 6 commits intomainfrom Nov 14, 2025
Conversation
…ation fo…" This reverts commit e699517.
…ents # Conflicts: # codex-rs/core/src/unified_exec/mod.rs
… and instantiation Refactor shell path detection and shell constructors to accept an optional explicit shell path. Update functions and internal logic to use the provided path if available, improving flexibility for custom shell locations. Adjust related tests and code paths to match new signatures.
- Use `ends_with` instead of `assert_eq!` for shell paths to support symlinks and variations - Consolidate Windows-specific tests and guard them with runtime `cfg!(windows)` checks - Update call to `get_shell` to include required argument - Remove redundant test module separation
pakrym-oai
deleted the
revert-6606-revert-6577-pakrym/shell-experiments
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #6606