[App server] add mcp tool call item started/completed events#6642
Merged
[App server] add mcp tool call item started/completed events#6642
Conversation
a118e66 to
0c383d0
Compare
0c383d0 to
0f4fd5a
Compare
386ca2f to
361925d
Compare
361925d to
cfcbbae
Compare
owenlin0
approved these changes
Nov 14, 2025
Collaborator
owenlin0
left a comment
There was a problem hiding this comment.
nice! looks straightforward 🙌
| use tokio::sync::oneshot; | ||
| use tracing::error; | ||
|
|
||
| type JsonRpcResult = serde_json::Value; |
Collaborator
There was a problem hiding this comment.
nit: can we call this type JsonValue?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this PR does two things:
apply_bespoke_event_handlinginto a separate file as it's getting kind of long;item/startedanditem/completedevents. To roll out app server events asap we didn't properly migrate mcp core events to use TurnItem for mcp tool calls - this will be a follow-up PR.real events generated in log: