Order outputs before inputs#6691
Merged
pakrym-oai merged 1 commit intomainfrom Nov 14, 2025
Merged
Conversation
| outputs_to_record.push(item); | ||
| } | ||
|
|
||
| let all_items_to_record = [outputs_to_record, new_inputs_to_record].concat(); |
Collaborator
There was a problem hiding this comment.
calling the function call as output is confusing to me. Because the output is now an new input. I don't have a better name tbh
aibrahim-oai
approved these changes
Nov 14, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For better caching performance all output items should be rendered in the order they were produced before all new input items (for example, all function_call before all function_call_output).