Add vim navigation keys to transcript pager#7550
Conversation
|
Not sure where the RUSTFLAGS tests instructions are coming from above Tested that this works locally. Testing this highlights a bug that the paging in transcript is incorrect (it skips 3 rows because it's not factoring in the header and footer). |
There was a problem hiding this comment.
yay ty.
some random thoughts:
i do feel like adding the instructions there make it too busy and isn't necessary. every vim user will just try to use those keys instinctively upon seeing a pager interface, and it's maybe uncommon enough to pollute that section.
also for a standard key equivalent for half-page, maybe <space> and shift+<space>.
I agree (I was 60/40 on it, so left it as is). Good to get some external confirmation - will fix.
We map space to full page down. Shift space makes sense to do full page up. Is there a reason for half page? |
aw-oai
left a comment
There was a problem hiding this comment.
We map space to full page down. Shift space makes sense to do full page up. Is there a reason for half page?
Ah okay. Nah I just didn't see any instructions in your screenshot for the half-page other than the vim binding, so was throwing a suggestion in case there wasn't a non-vim binding.
Thanks again
|
@codex fix the tests |
f6d6b59 to
d2a5622
Compare
|
Summary
Testing
|
- Ctrl+F / Ctrl+B for page down/up - Ctrl+D / Ctrl+U for half page down/up - Shift+Space for half page up
d2a5622 to
612157c
Compare

Summary
Codex Task