proposing execpolicy amendment when prompting due to sandbox denial#7653
Merged
proposing execpolicy amendment when prompting due to sandbox denial#7653
Conversation
zhao-oai
force-pushed
the
dev/zhao/sandbox-deny-amendment
branch
3 times, most recently
from
35d468b to
bd130e4
Compare
Contributor
Author
|
@codex review |
Contributor
|
Codex Review: Didn't find any major issues. Already looking forward to the next diff. ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
zhao-oai
force-pushed
the
dev/zhao/sandbox-deny-amendment
branch
from
bd130e4 to
5a520f0
Compare
bolinfest
approved these changes
Dec 6, 2025
Collaborator
bolinfest
left a comment
bolinfest
left a comment
There was a problem hiding this comment.
Overall looks good, but please try to tighten up the docstrings/naming.
zhao-oai
force-pushed
the
dev/zhao/sandbox-deny-amendment
branch
3 times, most recently
from
3f2d70e to
ced46c8
Compare
zhao-oai
force-pushed
the
dev/zhao/sandbox-deny-amendment
branch
from
ced46c8 to
f722e95
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, we only show the “don’t ask again for commands that start with…” option when a command is immediately flagged as needing approval. However, there is another case where we ask for approval: When a command is initially auto-approved to run within sandbox, but it fails to run inside sandbox, we would like to attempt to retry running outside of sandbox. This will require a prompt to the user.
This PR addresses this latter case