Avoid setpgid for inherited stdio on macOS#8691
Conversation
|
All contributors have signed the CLA ✍️ ✅ |
|
I have read the CLA Document and I hereby sign the CLA |
|
hey there -- ran into this issue while having Codex build some Elixir code for me. I'm not an expert in the core of the potential issue here, but problem + solution look reasonable to me, so I had Codex whip up this PR. Hope it's useful! Happy to hear feedback if not! |
|
@codex review |
|
Codex Review: Didn't find any major issues. Breezy! ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
|
@seeekr, thanks for the contribution! |
Summary
Testing
cargo build -p codex-cliGIT_CONFIG_GLOBAL=/dev/null GIT_CONFIG_NOSYSTEM=1 CARGO_BIN_EXE_codex=/Users/denis/Code/codex/codex-rs/target/debug/codex /opt/homebrew/bin/timeout 30m cargo test -p codex-core -p codex-execContext
This fixes macOS sandbox hangs for commands like
elixir -v/erl -noshell, where the child was moved into a new process group while still attached to the controlling TTY. See issue #8690.Authorship & collaboration
codex-cli 0.77.0.gpt-5.2-codex (xhigh).