fix(exec): improve stdin prompt decoding#9151
Conversation
|
@codex review |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 104f01baaf
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
Thanks for the contribution. Please see the code review feedback from Codex. I think it's highlighting a legitimate problem. |
liqiongyu
force-pushed
the
fix/exec-stdin-utf8
branch
from
591679d to
9c4863b
Compare
|
Addressed the automated review feedback: check for UTF-32 BOMs before UTF-16 so UTF-32 input fails fast with the intended unsupported-encoding error. Added UTF-16BE + UTF-32LE/BE tests. Tests: cargo test -p codex-exec; just fix -p codex-exec. |
|
@codex review |
1 similar comment
|
@codex review |
|
Codex Review: Didn't find any major issues. Keep them coming! ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
3 participants
Fixes #8733.
Tests:
cargo test -p codex-exec.