Conversation
gt-oai
approved these changes
Jan 20, 2026
|
|
||
| async fn fetch_and_update_models(&self) -> CoreResult<()> { | ||
| let _timer = | ||
| codex_otel::start_global_timer("codex.remote_models.fetch_update.duration_ms", &[]); |
Contributor
There was a problem hiding this comment.
it's weird to me that this timer metric name includes duration_ms -- surely units are already handled by the timer itself?
Collaborator
Author
There was a problem hiding this comment.
This is more for the collection part. It makes is non ambigious for the DS team building dashboards on top of this
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.