core: Match review test runtime threads on windows #3844
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The review integration tests spawn a wiremock server and the Codex conversation manager inside the same Tokio runtime; each of those launch long-lived async tasks to drive the SSE stream and event pump. On Windows the slower I/O frequently starves those tasks when we only offer two worker threads, which trips the `timeout waiting for event` guard in `wait_for_event`. The other review cases (`review_op_with_plain_text_emits_review_fallback`, `review_does_not_emit_agent_message_on_structured_output`, and `review_input_isolated_from_parent_history`) already bumped their Windows flavor to four worker threads after similar CI flakes. This change makes `review_op_emits_lifecycle_and_review_output` consistent so Windows runs stop intermittently hanging while Linux/macOS stay on two threads.
abhishek-oai
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The review integration tests spawn a wiremock server and the Codex conversation manager inside the same Tokio runtime; each of those launch long-lived async tasks to drive the SSE stream and event pump.
On Windows the slower I/O frequently starves those tasks when we only offer two worker threads, which trips the
timeout waiting for eventguard inwait_for_event.The other review cases (
review_op_with_plain_text_emits_review_fallback,review_does_not_emit_agent_message_on_structured_output, andreview_input_isolated_from_parent_history) already bumped their Windows flavor to four worker threads after similar CI flakes. This change makesreview_op_emits_lifecycle_and_review_outputconsistent so Windows runs stop intermittently hanging while Linux/macOS stay on two threads.