Skip to content

Conversation

@pakrym-oai
Copy link
Collaborator

@pakrym-oai pakrym-oai commented Oct 3, 2025

Use structured output and inline prompt messages.

@pakrym-oai
Copy link
Collaborator Author

@codex fix any issues you find with the change

Copy link
Contributor

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

const lines = [
'Potential duplicates detected:',
...numbers.map((value) => `- #${value}`),

P1 Badge Update duplicate comment step for new Codex output schema

The Codex invocation now requests an object that wraps the candidate issues under an issues array, yet the comment script still treats the parsed output as a bare array (numbers.map(...)). When Codex returns the new object shape, numbers becomes an object and .map throws, causing the job to fail before posting any comment. The consumer needs to read issues from the parsed object before iterating.


if ! printf '%s' "$json" | jq -e 'type == "array"' >/dev/null 2>&1; then
echo "Codex output was not a JSON array. Raw output: $json"
exit 0
fi

P1 Badge Apply-label step still expects JSON array

The gather step now defines an output_schema that returns an object with a labels array, but the apply step continues to validate codex_output with jq -e 'type == "array"' and iterates over it directly. With the new schema the output is a JSON object, so this check prints “Codex output was not a JSON array” and exits early, meaning no labels are ever applied. The script should parse the object and extract .labels before checking/looping.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting

@chatgpt-codex-connector
Copy link
Contributor

Summary

Testing

  • ⚠️ Tests not run (workflow-only changes).

View task →

@pakrym-oai pakrym-oai merged commit 3495a7d into main Oct 3, 2025
19 checks passed
@pakrym-oai pakrym-oai deleted the pakrym/modernize-workflows branch October 3, 2025 16:25
@github-actions github-actions bot locked and limited conversation to collaborators Oct 3, 2025
Copy link
Collaborator

@bolinfest bolinfest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very cool!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants