-
Notifications
You must be signed in to change notification settings - Fork 6.4k
Modernize workflows #4668
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Modernize workflows #4668
Conversation
|
@codex fix any issues you find with the change |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💡 Codex Review
codex/.github/workflows/issue-deduplicator.yml
Lines 108 to 110 in 2ac4dba
| const lines = [ | |
| 'Potential duplicates detected:', | |
| ...numbers.map((value) => `- #${value}`), |
The Codex invocation now requests an object that wraps the candidate issues under an issues array, yet the comment script still treats the parsed output as a bare array (numbers.map(...)). When Codex returns the new object shape, numbers becomes an object and .map throws, causing the job to fail before posting any comment. The consumer needs to read issues from the parsed object before iterating.
codex/.github/workflows/issue-labeler.yml
Lines 93 to 97 in 2ac4dba
| if ! printf '%s' "$json" | jq -e 'type == "array"' >/dev/null 2>&1; then | |
| echo "Codex output was not a JSON array. Raw output: $json" | |
| exit 0 | |
| fi | |
The gather step now defines an output_schema that returns an object with a labels array, but the apply step continues to validate codex_output with jq -e 'type == "array"' and iterates over it directly. With the new schema the output is a JSON object, so this check prints “Codex output was not a JSON array” and exits early, meaning no labels are ever applied. The script should parse the object and extract .labels before checking/looping.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting
|
Summary
Testing
|
bolinfest
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very cool!
Use structured output and inline prompt messages.