-
Notifications
You must be signed in to change notification settings - Fork 6.4k
Generate JSON schema for app-server protocol #5063
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
3d774ee
Export JSON Schema from the app server
rasmusrygaard 0d77bcb
undo
rasmusrygaard eb54160
gen
rasmusrygaard 95fe642
another one
rasmusrygaard eb55b68
fmt
rasmusrygaard ac8bd23
pmt
rasmusrygaard 591304d
update new enum
rasmusrygaard File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,22 @@ | ||
| use anyhow::Result; | ||
| use clap::Parser; | ||
| use std::path::PathBuf; | ||
|
|
||
| #[derive(Parser, Debug)] | ||
| #[command( | ||
| about = "Generate TypeScript bindings and JSON Schemas for the Codex app-server protocol" | ||
| )] | ||
| struct Args { | ||
| /// Output directory where generated files will be written | ||
| #[arg(short = 'o', long = "out", value_name = "DIR")] | ||
| out_dir: PathBuf, | ||
|
|
||
| /// Optional Prettier executable path to format generated TypeScript files | ||
| #[arg(short = 'p', long = "prettier", value_name = "PRETTIER_BIN")] | ||
| prettier: Option<PathBuf>, | ||
| } | ||
|
|
||
| fn main() -> Result<()> { | ||
| let args = Args::parse(); | ||
| codex_app_server_protocol::generate_types(&args.out_dir, args.prettier.as_deref()) | ||
| } | ||
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need a switch for cases that don't care about OpenAPI?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@codex add a switch to control this, turn it on by default
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Summary
--json-schemaflag to the export CLI so JSON Schema generation can be toggled while defaulting to the previous behavior. codex-rs/app-server-protocol/src/bin/export.rsL9-L30Testing
just fmtView task →