[app-server] read rate limits API #5302
Conversation
|
All contributors have signed the CLA ✍️ ✅ |
|
I have read the CLA Document and I hereby sign the CLA |
owenlin0
force-pushed
the
owen/rate_limit_api
branch
from
b72858c to
e19f662
Compare
owenlin0
force-pushed
the
owen/rate_limit_api
branch
5 times, most recently
from
20a6979 to
9665d21
Compare
owenlin0
force-pushed
the
owen/rate_limit_api
branch
from
9665d21 to
b4aec26
Compare
| } | ||
|
|
||
| async fn fetch_account_rate_limits(&self) -> Result<RateLimitSnapshot, JSONRPCErrorError> { | ||
| let Some(auth) = self.auth_manager.auth() else { |
There was a problem hiding this comment.
Can we have some helper for internal errors? We use them quite a lot and they are verbose.
There was a problem hiding this comment.
will follow up in a separate PR
https://linear.app/openai/issue/CLI-861/app-server-create-helpers-for-internal-errors
| std::fs::write(config_toml, format!("chatgpt_base_url = \"{base_url}\"\n")) | ||
| } | ||
|
|
||
| fn write_chatgpt_auth( |
There was a problem hiding this comment.
this is a lot of boilerplate unrelated to the feature, can we bump it into a shared helper? Do other tests do the same?
There was a problem hiding this comment.
created an auth_fixtures.rs helper file as an immediate step, but also will tackle a broader cleanup later: https://linear.app/openai/issue/CLI-862/app-server-fix-boilerplate-in-integration-tests
There was a problem hiding this comment.
seems like integration tests in app-server are pretty boilerplatey in general, so will have a refactor-focused PR
owenlin0
force-pushed
the
owen/rate_limit_api
branch
from
e0700b4 to
93bf412
Compare
2 participants
Adds a
GET account/rateLimits/readAPI to app-server. This calls the codex backend to fetch the user's current rate limits.This would be helpful in checking rate limits without having to send a message.
For calling the codex backend usage API, I generated the types and manually copied the relevant ones into
codex-backend-openapi-types. It'll be nice to extend our internal openapi generator to support Rust so we don't have to run these manual steps.External (non-OpenAI) Pull Request Requirements
Before opening this Pull Request, please read the dedicated "Contributing" markdown file or your PR may be closed:
https://github.com/openai/codex/blob/main/docs/contributing.md
If your PR conforms to our contribution guidelines, replace this text with a detailed and high quality description of your changes.