Create independent TurnContexts #5308
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| let services = SessionServices { | ||
| mcp_connection_manager: McpConnectionManager::default(), | ||
| session_manager: ExecSessionManager::default(), | ||
| unified_exec_manager: UnifiedExecSessionManager::default(), | ||
| notifier: UserNotifier::default(), | ||
| notifier: session_configuration.notify.clone(), | ||
| rollout: Mutex::new(None), |
There was a problem hiding this comment.
The new SessionConfiguration no longer defines a notify field, yet the test helper still tries to read session_configuration.notify.clone() when constructing SessionServices. This code will not compile because the field does not exist on the struct anymore, so any cargo test or build fails immediately. The notifier should be created directly from Config (as done in Session::new) or the field reintroduced.
Useful? React with 👍 / 👎.
- Pass OtelEventManager by reference in make_turn_context to avoid unnecessary clones - Replace turn_context variable in submission_loop with previous_context to accurately track state - Unify handling of Op::UserInput and Op::UserTurn; simplify code by reducing duplication - Update build_environment_update_item to accept Option<&Arc<TurnContext>> - Ensure environment updates and new turn contexts are handled correctly - Adjust related tests for
…ic to EnvironmentContext for TurnContext changes
# Conflicts: # codex-rs/core/src/codex.rs
2 participants
The goal of this change: