[MCP] Dedicated error message for GitHub MCPs missing a personal access token #5393
Conversation
| format!( | ||
| "GitHub MCP does not support OAuth. Log in by adding `bearer_token_env_var = GITHUB_PERSONAL_ACCESS_TOKEN` in the `mcp_servers.{server_name}` section of your config.toml" | ||
| ) |
There was a problem hiding this comment.
This message might be interpreted as suggesting to replace GITHUB_PERSONAL_ACCESS_TOKEN with the PAT rather than being an environment variable. Perhaps add a part of the message that says to set the variable or link to some info about why we don't support directly setting the PAT in the file and only allow it via an environment variable.
Probably this variable name should be CODEX_GITHUB_PAT or something similar as it's unlikely that a properly scoped PAT for codex should have full GITHUB access.
There was a problem hiding this comment.
Yeah, I tried to word smith this a bit to keep it short but can incorporate some of that.
I extracted this to a function to make it more testable, might as well write some 😄 Updated! |
2 participants
Because the GitHub MCP is one of the most popular MCPs and it confusingly doesn't support OAuth, we should make it more clear how to make it work so people don't think Codex is broken.
github/github-mcp-server#921 (comment)