[otel] init otel for app-server #5469
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pakrym-oai
reviewed
Oct 21, 2025
pakrym-oai
reviewed
Oct 21, 2025
codex-rs/app-server/src/lib.rs
Outdated
| })?; | ||
|
|
||
| let otel = | ||
| codex_core::otel_init::build_provider(&config, env!("CARGO_PKG_VERSION")) |
There was a problem hiding this comment.
is there anything we can do so the otel init isn't 35 lines?
There was a problem hiding this comment.
sure, can you take a look?
pakrym-oai
approved these changes
Oct 21, 2025
apanasenko-oai
force-pushed
the
anton_panasenko_app_server_otel
branch
from
7a6dcdf to
c74efd2
Compare
apanasenko-oai
force-pushed
the
anton_panasenko_app_server_otel
branch
from
c74efd2 to
83bb695
Compare
pakrym-oai
approved these changes
Oct 21, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.