[App Server] Allow fetching or resuming a conversation summary from the conversation id #5890
+93
−16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gpeal
changed the title
gpeal
force-pushed
the
gpeal/conversation-id-summary
branch
from
cb78efd to
a5b38e1
Compare
bolinfest
reviewed
Oct 29, 2025
| pub rollout_path: PathBuf, | ||
| #[serde(untagged)] | ||
| pub enum GetConversationSummaryParams { | ||
| /// Provide the absolute or CODEX_HOME‑relative rollout path directly. |
There was a problem hiding this comment.
For a relative path, we should require that it is "normalized," i.e., no funny stuff with ../ to read paths outside $CODEX_HOME/sessions.
Come to think of it, we should probably resolve the path to a canonical (or at least absolute without hitting disk: https://crates.io/crates/path-absolutize) and then verify it is under $CODEX_HOME/sessions, which is simpler.
There was a problem hiding this comment.
This just documents the existing behvaior, do you want me to update that as part of this PR?
There was a problem hiding this comment.
@gpeal It can be done in a separate PR, but I think it's important that it's done.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds an option to app server to allow conversation summaries to be fetched from just the conversation id rather than rollout path for convenience at the cost of some latency to discover the rollout path.
This convenience is non-trivial as it allows app servers to simply maintain conversation ids rather than rollout paths and the associated platform (Windows) handling associated with storing and encoding them correctly.